Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable spike replays using external files for coreneuron in memory mode #2871

Closed
wants to merge 2 commits into from

Conversation

WeinaJi
Copy link
Collaborator

@WeinaJi WeinaJi commented May 6, 2024

No description provided.

Copy link

✔️ 8b48c9a -> Azure artifacts URL

Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 67.17%. Comparing base (d99cbb5) to head (3d589c7).

Files Patch % Lines
src/coreneuron/io/core2nrn_data_return.cpp 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2871      +/-   ##
==========================================
- Coverage   67.18%   67.17%   -0.02%     
==========================================
  Files         564      564              
  Lines      104268   104277       +9     
==========================================
- Hits        70053    70045       -8     
- Misses      34215    34232      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

@bbpbuildbot

This comment has been minimized.

Copy link

✔️ 9e4c9f4 -> Azure artifacts URL

@WeinaJi WeinaJi marked this pull request as ready for review May 7, 2024 07:14
@WeinaJi WeinaJi requested a review from pramodk May 7, 2024 07:14
Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

✔️ 3d589c7 -> Azure artifacts URL

@WeinaJi
Copy link
Collaborator Author

WeinaJi commented Jun 6, 2024

This PR is not needed. We've decided to replay with netcons in CoreNeuron which should work with in memory transfer.

@WeinaJi WeinaJi closed this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants